[PATCH] D138639: [X86] Add In64BitMode for MOVSX64/MOVZX64 instructions

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 04:26:34 PST 2022


pengfei added a comment.

In D138639#3948608 <https://reviews.llvm.org/D138639#3948608>, @skan wrote:

> Hi @craig.topper , why do you think this may increase the size of the table in X86GenDAGISel.inc? 
> @HaohaiWen  Could you check how much the table grows with this patch?

I think it will increase 2 bytes for each pattern:

  /*Scope*/ 13, /*->133335*/
   OPC_CheckChild0Type, MVT::i32,
   OPC_CheckType, MVT::i64,
   OPC_CheckPatternPredicate, 8, // (Subtarget->is64Bit())     <-- increase here.
   OPC_MorphNodeTo1, TARGET_VAL(X86::MOVSX64rr32), 0,
       MVT::i64, 1/*#Ops*/, 0,
   // Src: (sext:{ *:[i64] } GR32:{ *:[i32] }:$src) - Complexity = 3
   // Dst: (MOVSX64rr32:{ *:[i64] } GR32:{ *:[i32] }:$src)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138639/new/

https://reviews.llvm.org/D138639



More information about the llvm-commits mailing list