[PATCH] D138339: [FuzzMutate] New strategy `ShuffleBlockStrategy`
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 22 14:29:40 PST 2022
arsenm added inline comments.
================
Comment at: llvm/unittests/FuzzMutate/StrategiesTest.cpp:366
+
+ auto M = parseAssembly(Source.data(), Ctx);
+ Function *F = &*M->begin();
----------------
Peter wrote:
> arsenm wrote:
> > Module *M
> `parseAssembly` returns a unique pointer so we don't have to explicitly free the memory.
> I think we are better off with `auto`. Besides, every other test did the same.
That makes things worse. I think auto is harmful here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138339/new/
https://reviews.llvm.org/D138339
More information about the llvm-commits
mailing list