[PATCH] D138339: [FuzzMutate] New strategy `ShuffleBlockStrategy`

[Peter Rong via Phabricator via llvm-commits]

Peter marked an inline comment as not done.
Peter added inline comments.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:318-321
+      if (P && AliveInsts.count(P))
+        return false;
+    }
+    return true;
----------------
arsenm wrote:
> The return values look backwards to me?
Thanks for pointing that out. It is backwards.


================
Comment at: llvm/unittests/FuzzMutate/StrategiesTest.cpp:366
+
+  auto M = parseAssembly(Source.data(), Ctx);
+  Function *F = &*M->begin();
----------------
arsenm wrote:
> Module *M
`parseAssembly` returns a unique pointer so we don't have to explicitly free the memory. 
I think we are better off with `auto`. Besides, every other test did the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138339/new/

https://reviews.llvm.org/D138339