[PATCH] D138352: [RISCV] Support .variant_cc directive for the assembler.

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 21:18:16 PST 2022


fakepaper56 marked 2 inline comments as done.
fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2317
+
+  // There shouldn't be any more tokens.
+  if (!Parser.parseEOL("unexpected token in '.variant_cc' directive"))
----------------
MaskRay wrote:
> This code self explains so the comment seems redundant. You may delete the blank line after `Parser.Lex()` as well.
I use default `expected newline` for the token missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138352/new/

https://reviews.llvm.org/D138352



More information about the llvm-commits mailing list