[PATCH] D138372: Updates and adds tests for i386/ELF JITLink backend

[Sunho Kim via Phabricator via llvm-commits]

sunho accepted this revision.
sunho added a comment.
This revision is now accepted and ready to land.

LGTM to me in general. Few minor comments.



================
Comment at: llvm/test/ExecutionEngine/JITLink/i386/ELF_i386_absolute_relocations_16.s:1
+# RUN: llvm-mc -triple=i386-unknown-linux-gnu -filetype=obj --show-encoding --show-inst -o %t.o %s
+# RUN: llvm-jitlink -noexec \
----------------
Is --show-encoding --show-inst  needed?


================
Comment at: llvm/test/ExecutionEngine/JITLink/i386/ELF_i386_pc_relative_relocations_32.s:23
+        .type   bar, at function
+bar:
+    calll foo
----------------
Maybe it's worth to rename functions to be more descriptive. Like test_pc_rel_pos.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138372/new/

https://reviews.llvm.org/D138372