[PATCH] D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 20 02:54:20 PST 2022


RKSimon added a comment.

In D138359#3939621 <https://reviews.llvm.org/D138359#3939621>, @pengfei wrote:

> 



> We can only find one overridden pair each time, right?

Yes each warning is per instruction + per model - e.,g. there are usually 2 warnings for the znver1/2 overrides as they are basically copies of each other.

The x86 cases I'm slowly working through as I'm confident about what is going on - but for other targets my concern is that they've ended up with at least some overrides just so each model has the same entries, even though some are redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138359/new/

https://reviews.llvm.org/D138359



More information about the llvm-commits mailing list