[PATCH] D137936: [AArch64] Optimize cmp chain before legalization

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 03:31:24 PST 2022


bcl5980 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:8574
   }
 
   // All the non-leaf nodes must be OR.
----------------
Maybe the ISD::ZERO_EXTEND can remain here?


================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-setcc.ll:224
 ; CHECK-NEXT:    sbc x9, x3, x10
-; CHECK-NEXT:    ccmp x3, x10, #0, eq
-; CHECK-NEXT:    b.ne .LBB12_1
+; CHECK-NEXT:    cset w11, ne
+; CHECK-NEXT:    cmp x3, x10
----------------
Looks regression for this case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137936/new/

https://reviews.llvm.org/D137936



More information about the llvm-commits mailing list