[PATCH] D137725: [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 13:53:47 PST 2022


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:84
+  /// Separator used between all of the rest consecutive parts of s name
+  StringRef Separator;
+
----------------
This will move into the config object now, right? Can we also avoid the user telling us the string refs and instead determining them on the rest of the config?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137725/new/

https://reviews.llvm.org/D137725



More information about the llvm-commits mailing list