[PATCH] D137725: [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin added a comment.

In D137725#3930994 <https://reviews.llvm.org/D137725#3930994>, @jdoerfert wrote:

> In D137725#3930985 <https://reviews.llvm.org/D137725#3930985>, @jsjodin wrote:
>
>> I'm currently working on using llvm::Optional for the various attiibutes, since that is more flexible. Let me know if you have any other ideas how to handle this.
>
> Optional is good, for the fields or the config object. Alternatively defaults as we can derive them would be OK too. A mix might be good, if we can derive a sensible default, we use it, if not, it's Optional and None.

Just for reference the patch is here: https://reviews.llvm.org/D138220


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137725/new/

https://reviews.llvm.org/D137725