[PATCH] D138311: [RISCV][CodeGen] Chapter of vector instruction type corresponds with chapters in RISCV vector specification. NFC

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 10:12:25 PST 2022


michaelmaitland created this revision.
michaelmaitland added reviewers: craig.topper, kito-cheng.
Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson.
Herald added a project: All.
michaelmaitland requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

The vector spec <https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc> is organized in chapters
based on instruction type. The comments in the tablegen marked the incorrect chapters. This change
updates the comments with the correct chapter numbers.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138311

Files:
  llvm/lib/Target/RISCV/RISCVScheduleV.td


Index: llvm/lib/Target/RISCV/RISCVScheduleV.td
===================================================================
--- llvm/lib/Target/RISCV/RISCVScheduleV.td
+++ llvm/lib/Target/RISCV/RISCVScheduleV.td
@@ -613,7 +613,7 @@
 defm "" : LMULWriteRes<"WriteVIMovX", []>;
 defm "" : LMULWriteRes<"WriteVIMovI", []>;
 
-// 13. Vector Fixed-Point Arithmetic Instructions
+// 12. Vector Fixed-Point Arithmetic Instructions
 def : WriteRes<WriteVSALUV, []>;
 def : WriteRes<WriteVSALUX, []>;
 def : WriteRes<WriteVSALUI, []>;
@@ -628,7 +628,7 @@
 def : WriteRes<WriteVNClipX, []>;
 def : WriteRes<WriteVNClipI, []>;
 
-// 14. Vector Floating-Point Instructions
+// 13. Vector Floating-Point Instructions
 def : WriteRes<WriteVFALUV, []>;
 def : WriteRes<WriteVFALUF, []>;
 def : WriteRes<WriteVFWALUV, []>;
@@ -661,7 +661,7 @@
 def : WriteRes<WriteVFNCvtFToIV, []>;
 def : WriteRes<WriteVFNCvtFToFV, []>;
 
-// 15. Vector Reduction Operations
+// 14. Vector Reduction Operations
 def : WriteRes<WriteVIRedV, []>;
 def : WriteRes<WriteVIWRedV, []>;
 def : WriteRes<WriteVFRedV, []>;
@@ -669,7 +669,7 @@
 def : WriteRes<WriteVFWRedV, []>;
 def : WriteRes<WriteVFWRedOV, []>;
 
-// 16. Vector Mask Instructions
+// 15. Vector Mask Instructions
 def : WriteRes<WriteVMALUV, []>;
 def : WriteRes<WriteVMPopV, []>;
 def : WriteRes<WriteVMFFSV, []>;
@@ -764,7 +764,7 @@
 defm "" : LMULReadAdvance<"ReadVIMovV", 0>;
 defm "" : LMULReadAdvance<"ReadVIMovX", 0>;
 
-// 13. Vector Fixed-Point Arithmetic Instructions
+// 12. Vector Fixed-Point Arithmetic Instructions
 def : ReadAdvance<ReadVSALUV, 0>;
 def : ReadAdvance<ReadVSALUX, 0>;
 def : ReadAdvance<ReadVAALUV, 0>;
@@ -776,7 +776,7 @@
 def : ReadAdvance<ReadVNClipV, 0>;
 def : ReadAdvance<ReadVNClipX, 0>;
 
-// 14. Vector Floating-Point Instructions
+// 13. Vector Floating-Point Instructions
 def : ReadAdvance<ReadVFALUV, 0>;
 def : ReadAdvance<ReadVFALUF, 0>;
 def : ReadAdvance<ReadVFWALUV, 0>;
@@ -810,7 +810,7 @@
 def : ReadAdvance<ReadVFNCvtFToIV, 0>;
 def : ReadAdvance<ReadVFNCvtFToFV, 0>;
 
-// 15. Vector Reduction Operations
+// 14. Vector Reduction Operations
 def : ReadAdvance<ReadVIRedV, 0>;
 def : ReadAdvance<ReadVIRedV0, 0>;
 def : ReadAdvance<ReadVIWRedV, 0>;
@@ -824,7 +824,7 @@
 def : ReadAdvance<ReadVFWRedOV, 0>;
 def : ReadAdvance<ReadVFWRedOV0, 0>;
 
-// 16. Vector Mask Instructions
+// 15. Vector Mask Instructions
 def : ReadAdvance<ReadVMALUV, 0>;
 def : ReadAdvance<ReadVMPopV, 0>;
 def : ReadAdvance<ReadVMFFSV, 0>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138311.476521.patch
Type: text/x-patch
Size: 2488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221118/f6850472/attachment.bin>


More information about the llvm-commits mailing list