[PATCH] D138220: [OpenMP][OMPIRBuilder] Add a configuration class to captures flags/attributes that affect codegen

Jan Sjödin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 11:09:43 PST 2022


jsjodin added a comment.

In D138220#3934395 <https://reviews.llvm.org/D138220#3934395>, @tschuett wrote:

> `Optional<bool>` is an odd data structure. I would use enums instead to describe the different states.

It is the standard data structure used in LLVM to encode optional data. Why would using an enum be better?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138220/new/

https://reviews.llvm.org/D138220



More information about the llvm-commits mailing list