[PATCH] D138220: [OpenMP][OMPIRBuilder] Add a configuration class to captures flags/attributes that affect codegen

[Thorsten via Phabricator via llvm-commits]

tschuett added a comment.

`Optional<bool>` is an odd data structure. I would use enums instead to describe the different states.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:83
+public:
+  /// Flag for specifying if the comilation is done for embedded device code or
+  /// host code.
----------------
compilation


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138220/new/

https://reviews.llvm.org/D138220