[PATCH] D136377: [mlir][MemRefToLLVM] Remove the code for lowering subview

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet updated this revision to Diff 475931.
qcolombet retitled this revision from "[mlir][MemRefToLLVM] Reuse existing subview lowering" to "[mlir][MemRefToLLVM] Remove the code for lowering subview".
qcolombet edited the summary of this revision.
qcolombet added a comment.
Herald added a subscriber: Moerafaat.

- Update the description of the PR.
- Use the simplify-extract-strided-metadata as the expand-memref pass. (Will rename that pass in a different patch.)
- Move the tests related to subviews from memref-to-llvm to a new file that first run the expand pass.

Note: As far as code gen goes, the new lowering produces the same codegen after LLVM CSE or instcombine. Some examples for `collapse_shape` are available at https://reviews.llvm.org/D136483


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136377/new/

https://reviews.llvm.org/D136377

Files:
  mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
  mlir/test/Conversion/MemRefToLLVM/expand-then-convert-to-llvm.mlir
  mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136377.475931.patch
Type: text/x-patch
Size: 76070 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221116/a8bb56b9/attachment.bin>