[PATCH] D111777: [GlobalISel] Refactor CSEMIRBuilder's handling of unary op constant folding. NFC.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.
Herald added a project: All.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/Utils.h:283
+/// G_CONSTANT instructions as needed.
+Optional<MachineInstr *>
+ConstantFoldVectorUnaryOp(unsigned Opcode, const Register Op,
----------------
I'm not the biggest fan of Optional on pointers. It's not really any safer than the raw pointer for C++ and more syntactically awkward


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111777/new/

https://reviews.llvm.org/D111777