[PATCH] D137905: [GlobalISel] Add new G_INVOKE_REGION_START/END instructions to fix an EH bug
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 16 15:08:26 PST 2022
aemerson added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:258
+MachineBasicBlock::iterator MachineBasicBlock::getFirstTerminatorForward() {
+ iterator I = begin(), E = end();
+ while (I != E && !I->isTerminator())
----------------
paquette wrote:
> paquette wrote:
> > `find_if`?
> Should we check for debug instructions + skip them here like in `getFirstTerminator()`, or is that not necessary?
I don't think it's necessary since debug instructions would never be terminators.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137905/new/
https://reviews.llvm.org/D137905
More information about the llvm-commits
mailing list