[PATCH] D137905: [GlobalISel] Add new G_INVOKE_REGION_START/END instructions to fix an EH bug

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 13:58:10 PST 2022


paquette added a comment.

Does `G_INVOKE_REGION_START` work with the `terminators()` iterator?



================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:258
+MachineBasicBlock::iterator MachineBasicBlock::getFirstTerminatorForward() {
+  iterator I = begin(), E = end();
+  while (I != E && !I->isTerminator())
----------------
paquette wrote:
> `find_if`?
Should we check for debug instructions + skip them here like in `getFirstTerminator()`, or is that not necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137905/new/

https://reviews.llvm.org/D137905



More information about the llvm-commits mailing list