[PATCH] D138104: [AMDGPU] Precommit add_shr_carry test
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 16 14:57:25 PST 2022
arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/test/CodeGen/AMDGPU/add_shr_carry.ll:53
+}
+
+define i64 @basic_cst_32leadingzeroes(i32 %b, i64 %c) {
----------------
arsenm wrote:
> Add some negative cases where the shift amount is wrong, and the type sizes aren't right
Also as noted in the other review, multi use test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138104/new/
https://reviews.llvm.org/D138104
More information about the llvm-commits
mailing list