[PATCH] D137461: [LoopInterchange] Refactor and rewrite validDepInterchange()

Wed Nov 16 12:04:13 PST 2022

bmahjour accepted this revision.
bmahjour added a comment.

In D137461#3931498 <https://reviews.llvm.org/D137461#3931498>, @Narutoworld wrote:

> In D137461#3931490 <https://reviews.llvm.org/D137461#3931490>, @bmahjour wrote:
>
>>> The two changes (Direction == '*' and checking the dep vector before doing the interchange) may add safety, but also cause tests to fail.
>>
>> @Narutoworld your latest patch calls isLexicographicallyPositive once before the swap and once afterwards, and I don't see any XFAILed tests in your update. Have you check to see if all LIT tests pass?
>
> Hi @bmahjour 
> I have run the whole LIT tests with `ninja check-all`. No failed tests found.

Thanks. LGTM then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137461/new/

https://reviews.llvm.org/D137461