[PATCH] D137461: [LoopInterchange] Refactor and rewrite validDepInterchange()
MengXuan Cai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 16 11:41:37 PST 2022
Narutoworld added a comment.
In D137461#3931490 <https://reviews.llvm.org/D137461#3931490>, @bmahjour wrote:
>> The two changes (Direction == '*' and checking the dep vector before doing the interchange) may add safety, but also cause tests to fail.
>
> @Narutoworld your latest patch calls isLexicographicallyPositive once before the swap and once afterwards, and I don't see any XFAILed tests in your update. Have you check to see if all LIT tests pass?
Hi @bmahjour
I have run the whole LIT tests with `ninja check-all`. No failed tests found.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137461/new/
https://reviews.llvm.org/D137461
More information about the llvm-commits
mailing list