[PATCH] D137574: PEI should be able to use backward walk in replaceFrameIndicesBackward.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 11:21:57 PST 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1455
+  const TargetRegisterInfo &TRI = *MF.getSubtarget().getRegisterInfo();
+
+  RS->enterBasicBlockEnd(*BB);
----------------
unneeded excess blank lines


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1495
+      // Shift back
+      Step--;
+
----------------
LLVM style prefer `--Step`. Ditto elsewhere


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137574/new/

https://reviews.llvm.org/D137574



More information about the llvm-commits mailing list