[PATCH] D137918: [nfc] move expensive parts of Hashing.h into cpp file

Mon Nov 14 11:28:36 PST 2022

dblaikie added inline comments.

================
Comment at: llvm/include/llvm/ADT/Hashing.h:51
 #include "llvm/Support/type_traits.h"
 #include <algorithm>
 #include <cassert>
----------------
Trass3r wrote:
> Trass3r wrote:
> > It'd be good to get rid of this completely since it shows up at the top of the expensive includes list but there's a non-trivial usage left below.
> https://github.com/Trass3r/llvm-project/actions/runs/3458979320/jobs/5773908563#check-step-6
> ```
> *** Expensive headers:
> 1461737 ms: lvm/include/llvm/ADT/Hashing.h (included 5485 times, avg 266 ms), included via:
> 1269781 ms: /usr/include/c++/11/algorithm (included 5535 times, avg 229 ms), included via:
> 987320 ms: /usr/include/c++/11/pstl/glue_algorithm_defs.h (included 5535 times, avg 178 ms), included via:
> ```
Do you have stats on how much this patch changes those numbers? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137918/new/

https://reviews.llvm.org/D137918