[PATCH] D114174: [ARM][CodeGen] Add support for complex deinterleaving

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

OK great. Thanks for the updates. I think this looks to be in a good state now. We can always do more nitpicking, and but it looks to be in a good state to get into tree. We can get this in now and add AArch64 support on top to increase the test coverage.

Some minor comments below but otherwise LGTM.



================
Comment at: llvm/include/llvm/InitializePasses.h:114
 void initializeConstantMergeLegacyPassPass(PassRegistry&);
-void initializeConstraintEliminationPass(PassRegistry &);
+void initializeConstraintEliminationPass(PassRegistry&);
 void initializeCorrelatedValuePropagationPass(PassRegistry&);
----------------
You can undo these.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:590
+  UncommonImagOp = (CommonOperand == I0) ? I1 : I0;
+  if (Rotation == ComplexDeinterleavingRotation::Rotation_90 || Rotation == ComplexDeinterleavingRotation::Rotation_270)
+    std::swap(UncommonRealOp, UncommonImagOp);
----------------
Formatting.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:21795
+    Instruction *I, ComplexDeinterleavingOperation OperationType,
+    ComplexDeinterleavingRotation Rotation, Value *InputA, Value *InputB, Value *Accumulator) const {
+
----------------
Formatting.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:21803
+
+  assert(TyWidth >= 128);
+
----------------
Add a message to the assert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114174/new/

https://reviews.llvm.org/D114174