[PATCH] D137571: [AArch64] Add all SME2.1 instructions Assembly/Disassembly

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 04:51:46 PST 2022


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

One final request but otherwise looks good.



================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:4397
+multiclass sme2p1_luti4_vector_vg4_index<string mnemonic> {
+  def _S: sme2p1_luti4_vector_vg4_index<mnemonic>;
+}
----------------
This should be `_H`? Please can this multiclass take the same parameters as `sme2p1_luti2_vector_vg4_index`? I know it seems redundant but it'll make things easier if other variants are added later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137571/new/

https://reviews.llvm.org/D137571



More information about the llvm-commits mailing list