[PATCH] D137799: [WIP][llvm-driver] Pass extra arguments to tools

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 22:32:57 PST 2022


abrachet marked 3 inline comments as done.
abrachet added inline comments.


================
Comment at: llvm/cmake/modules/llvm-driver-template.cpp.in:11
 
-int main(int argc, char **argv) { return @TOOL_NAME at _main(argc, argv); }
+int @TOOL_NAME at _main(int argc, char **argv, const llvm::LLVMDriverExtraArgs &);
+
----------------
phosek wrote:
> Since we're no longer trying to match the signature of `main`, we could also consider other changes, for example passing args as a `ArrayRef<const char *>`, but that could be done in some future changes.
> but that could be done in some future changes.
I think I'll do that in the future because that would be a pretty involved change to the tools respective main functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137799/new/

https://reviews.llvm.org/D137799



More information about the llvm-commits mailing list