[PATCH] D137893: [AsmWriter] Do not write a comma when varargs is the only argument
Joshua Cao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 13 19:29:06 PST 2022
caojoshua added a comment.
I have my git commit in in my github fork <https://github.com/caojoshua/llvm-project/commit/50a55613441151671f6a49982acea9fb043f7d5e>
commit 50a55613441151671f6a49982acea9fb043f7d5e
Author: Joshua Cao <cao.joshua at yahoo.com>
Date: Sun Nov 13 22:24:15 2022 -0500
[AsmWriter] Do not write a comma when varargs is the only argument
Fixes https://github.com/llvm/llvm-project/issues/56544
AsmWriter always writes ", ..." when a tail call has a varargs argument. This patch only writes the ", " when there is an argument before the varargs argument.
I did not write a dedicated test this for this change, but I modified an existing test that will test for a regression.
Reviewed By: avogelsgesang
Differential Revision: https://reviews.llvm.org/D137893
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137893/new/
https://reviews.llvm.org/D137893
More information about the llvm-commits
mailing list