[PATCH] D137904: [RISCV] Provide a isOneSourceVECTOR_SHUFFLE function. NFC.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 16:14:14 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2734
+// index) vector, return the vector. Otherwise, return SDValue().
+static SDValue isOneSourceVECTOR_SHUFFLE(SDValue N0, SDValue N1,
+                                         ArrayRef<int> Mask) {
----------------
I kind of think a function starting with `is` should return a bool. Maybe `getSingleShuffleSource`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137904/new/

https://reviews.llvm.org/D137904



More information about the llvm-commits mailing list