[PATCH] D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types

Trass3r via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 15:59:34 PST 2022


Trass3r added a comment.

See https://github.com/llvm/llvm-project/issues/57525.
The change is focused on those cases reported by gcc, i.e. with actual devirtualization potential.
It needs to be carefully checked if some of those shouldn't be final (and could we somehow mark those as intended for subclassing, along the lines of `class F /*non-final*/ : ...`?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137920/new/

https://reviews.llvm.org/D137920



More information about the llvm-commits mailing list