[PATCH] D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine
Alexey Baturo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 13 00:09:33 PST 2022
smd added a comment.
In D132994#3923439 <https://reviews.llvm.org/D132994#3923439>, @jrtc27 wrote:
> It seems we're missing a emitDirectiveVariantCC equivalent to AArch64's emitDirectiveVariantPCS, which is what should be used here I believe otherwise Luis is right, the assembly doesn't mark the symbol as a variant CC one, so round-tripping through assembly loses the flag.
>
> What you showed is still compiling directly from C to an object file with the integrated assembler; you'd need to either use -no-integrated-as or use -S and then assemble the .s file.
Indeed asm file lacks .variant_cc annotation.
I doubt supporting emitDirectiveVariantCC should be a part of this particular patch, so what's the best way to handle this situation?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132994/new/
https://reviews.llvm.org/D132994
More information about the llvm-commits
mailing list