[PATCH] D137893: [AsmWriter] Do not write a comma when varargs is the only argument
Joshua Cao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 12 17:44:25 PST 2022
caojoshua added a comment.
In D137893#3923303 <https://reviews.llvm.org/D137893#3923303>, @avogelsgesang wrote:
> LGTM, with small nit:
>
> There is a typo in the commit description
>
>> I did not write a dedicated this for this change
>
> should be
>
>> I did not write a dedicated test for this change
>
> Please fix before merging
Thank you. I fixed it.
Can I get help pushing this? This is my first contribution, and I do not have permissions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137893/new/
https://reviews.llvm.org/D137893
More information about the llvm-commits
mailing list