[PATCH] D137532: [LoongArch] Implement the TargetLowering::getRegisterByName hook

[Lu Weining via Phabricator via llvm-commits]

SixWeining added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/get-noreg.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: not --crash llc < %s --mtriple=loongarch64 2>&1 | FileCheck %s
+
----------------
`crash` may slow down the test. Could we not add such tests?


================
Comment at: llvm/test/CodeGen/LoongArch/get-reg-error.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: not --crash llc < %s --mtriple=loongarch64 2>&1 | FileCheck %s
+
----------------
Ditto.


================
Comment at: llvm/test/CodeGen/LoongArch/get-reg-reserve.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s --mtriple=loongarch64 | FileCheck %s
----------------
I suggest to rename `get-reg-reserve.ll` to `get-reg.ll` since `get-reg-reserve.ll` may imply we support getting non-reserved registers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137532/new/

https://reviews.llvm.org/D137532