[PATCH] D137837: [Support] Move Target/CPU Printing out of CommandLine

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 23:09:21 PST 2022


MaskRay added a comment.

Personally I think the CPU info is not useful for all tools. 
For most programs I have run which support `--version`, they don't print target-triple/CPU information. So LLVM CommandLine.cpp doing this by default is very strange to me.
I see that you want to retain the existing behavior, though. I want to learn about others opinions. Perhaps ask on Discourse?

I mentioned `llvm/Support/Host.h` but that was for a middle ground if there turns out to be sufficient support for retaining the information. So I suggested: for the tools which have `+ #include "llvm/Support/Host.h"` in this diff, I think `cl::AddExtraVersionPrinter` should be dropped.
But perhaps we just don't need to do that :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137837/new/

https://reviews.llvm.org/D137837



More information about the llvm-commits mailing list