[PATCH] D137848: [ConstraintElimination] Add Decomposition class (NFCI)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 16:03:49 PST 2022


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:196
+/// Represents an Offset + Coefficient1 * Variable1 + ... decomposition.
+struct Decomposition {
+  int64_t Offset = 0;
----------------
Could this be a `class` instead of a `struct` to ensure the offsets are only adjusted using the safe methods?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137848/new/

https://reviews.llvm.org/D137848



More information about the llvm-commits mailing list