[PATCH] D137847: [ConstraintElimination] Make decompose() infallible
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 11 16:00:59 PST 2022
fhahn accepted this revision.
fhahn added reviewers: zjaffal, fcloutier.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
IIRC the main reason was that `{}` originally was more compact. With respect to correctness, always returning `0 + V` is fine and in combination with the constructors from D137848 <https://reviews.llvm.org/D137848> the code will end up still compact.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137847/new/
https://reviews.llvm.org/D137847
More information about the llvm-commits
mailing list