[PATCH] D137655: Expand fminimum/fmaximum into fminnum/fmaxnum + NaN check

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D137655#3922642 <https://reviews.llvm.org/D137655#3922642>, @arsenm wrote:

> In D137655#3921056 <https://reviews.llvm.org/D137655#3921056>, @nikic wrote:
>
>> I don't have access to the 2019 spec, but as far as I know it specifies both minimum and minimumNumber, where minimumNumber is 2008 minnum with a) specified signed zero behavior and b) fixed sNaN behavior (i.e. the FMINNUM rather than FMINNUM_IEEE behavior). That's what I meant by the 2019 minnum semantics.
>
> OK, yes I was confused by the name change. "minimum" is basically the same with the specified signed zero behavior. Regardless, we should have another pair of min/max with the defined signed zero handling

Alternatively, since I believe we don't actually have any users that don't specify the correct signed zero handling, we could just redefine FMINNUM_IEEE/FMAXNUM_IEEE to have the new behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137655/new/

https://reviews.llvm.org/D137655