[PATCH] D136702: [llvm-cov] Look up object files using debuginfod.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added inline comments.


================
Comment at: llvm/tools/llvm-cov/CodeCoverage.cpp:656
+  cl::opt<bool> Debuginfod(
+      "debuginfod", cl::Optional,
+      cl::desc("Use debuginfod to look up object files from profile"),
----------------
ellis wrote:
> I personally prefer `cl::ZeroOrMore` rather than `cl::Optional` because I believe `cl::Optional` will fail if this option occurs twice. Does that make sense for these options?
SGTM; I'm generally a fan of the the last-flag-wins semantics as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136702/new/

https://reviews.llvm.org/D136702