[PATCH] D119547: [libc][bazel] Add tests to the bazel build

Fri Nov 11 12:52:41 PST 2022

sivachandra added a comment.

In D119547#3908018 <https://reviews.llvm.org/D119547#3908018>, @gchatelet wrote:

> @GMNGeoffrey @sivachandra can we update the bazel builder?

Sorry, I missed this - I do not maintain the bazel builder so this question should probably be answered by someone who maintains it.

================
Comment at: utils/bazel/llvm-project-overlay/libc/test/libc_test_rules.bzl:16
+    if "deps" in kw:
+        fail("A libc_test target should list 'libc_function_deps' and " +
+             "'additional_deps' instead of 'deps'.")
----------------
gchatelet wrote:
> GMNGeoffrey wrote:
> > It seems like calling the "additional_deps" argument "deps" would also be fine? Generally it's preferred to use standard names (https://bazel.build/rules/bzl-style). I do see the argument for different naming, thouhg. Your call
> @sivachandra WDYT?
Fine with calling it `deps`. IIRC, I named it `additional_deps` and not `deps` so that we do not mistakenly end up putting `libc_function_deps` in `deps`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119547/new/

https://reviews.llvm.org/D119547