[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, minor nits. Nice cleanup.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729
+                                              const llvm::StringRef &Name,
+                                              unsigned AddressSpace = 0);
 };
----------------
No `llvm::`. Can you check your future patches for these things, please.
StringRef is passed by value not reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137720/new/

https://reviews.llvm.org/D137720