[PATCH] D137230: [XCOFF] avoid unnecessary Fixups when -function-sections is enabled.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 11:56:33 PST 2022


DiggerLin accepted this revision.
DiggerLin added a comment.
This revision is now accepted and ready to land.

LGTM, please wait for several days and Hubert maybe has comment on it. I do not think we need to check so many symbol items and relocation items in the test case, but I can not give any suggestion on it.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-funcsect.ll:15
+; RUN:     -mattr=-altivec -function-sections -xcoff-traceback-table=true \
+; RUN:     -filetype=obj -o %t.o < %s
+; RUN: llvm-objdump --syms --reloc %t.o | FileCheck --check-prefix=XCOFF64 %s
----------------
nit: change %t64.o 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-funcsect.ll:16
+; RUN:     -filetype=obj -o %t.o < %s
+; RUN: llvm-objdump --syms --reloc %t.o | FileCheck --check-prefix=XCOFF64 %s
+
----------------
nit: change %t64.o


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137230/new/

https://reviews.llvm.org/D137230



More information about the llvm-commits mailing list