[PATCH] D137796: Remove TargetMachine::adjustPassManager

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D137796#3921661 <https://reviews.llvm.org/D137796#3921661>, @aeubanks wrote:

> could I have a couple days until submitting this? we have one more internal usage of this

Sure. No hurry from my side really.



================
Comment at: llvm/docs/NewPassManager.rst:526
+removed in opt the function isn't needed any longer. In the new PM such
+adjustments is done by using ``TargetMachine::registerPassBuilderCallbacks()``.
 
----------------
aeubanks wrote:
> Readers might think that they have to add code to do this. It was already mentioned above that PassBuilder automatically does this, but I think reiterating that this is done automatically would be good
I guess the important thing here is to guide anyone that hasn't migrated yet, and suddenly realize that adjustPassManager is gone, that whatever was in adjustPassManager() needs to be added in registerPassBuilderCallbacks() instead.

Maybe I just complicated things by trying to also mention that we now have removed the old adjustPassManager function. It was a bit weird to reference a function that no longer exists. One idea is to more or less restore the old text here, but add a note that adjustPassManager has been removed from the code base.

Anyway, I'll try to rephrase this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137796/new/

https://reviews.llvm.org/D137796