[PATCH] D136702: [llvm-cov] Look up object files using debuginfod.

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-cov.rst:352
 
+.. option:: -debuginfod
+
----------------
Can we add a test that uses this option? Maybe a test to make sure we can disable it without problem.


================
Comment at: llvm/tools/llvm-cov/CodeCoverage.cpp:656
+  cl::opt<bool> Debuginfod(
+      "debuginfod", cl::Optional,
+      cl::desc("Use debuginfod to look up object files from profile"),
----------------
I personally prefer `cl::ZeroOrMore` rather than `cl::Optional` because I believe `cl::Optional` will fail if this option occurs twice. Does that make sense for these options?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136702/new/

https://reviews.llvm.org/D136702