[PATCH] D137723: [PDB] Don't include input files in the 'cmd' entry of S_ENVBLOCK
Sylvain Audi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 11 09:02:22 PST 2022
saudi marked an inline comment as done.
saudi added inline comments.
================
Comment at: lld/COFF/DriverUtils.cpp:859
+ // the PDB if necessary. Mimic MSVC, which skips input files.
+ config->argv = {argv.data(), argv.data() + 1};
+ for (opt::Arg *arg : args) {
----------------
thakis wrote:
> Instead of this line, maybe `config->argv.push_back(argv[0]);`? Maybe a bit more direct.
replacing with `= {argv[0]}` to keep the previous behavior concerning re-initialization of `config->argv`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137723/new/
https://reviews.llvm.org/D137723
More information about the llvm-commits
mailing list