[PATCH] D137783: [AMDGPU][MC] Support TFE modifiers in MUBUF loads and stores.

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2287
   }
-  multiclass MUBUF_Real_AllAddr_Lds_gfx10<bits<8> op> {
+  multiclass MUBUF_Real_AllAddr_gfx10<bits<8> op, bit noTFE = 0> {
+    defm NAME : MUBUF_Real_AllAddr_Helper_gfx10<op>;
----------------
kosarev wrote:
> dp wrote:
> > Is there a reason to use both `isTFE` and `noTFE`? The expressions like `!not(noTFE)` are difficult to read.
> `noTFE` means we don't want the TFE version, for which `isTFE` is true, so not the same thing. `!not(noTFE)` indeed catches the eye, but I have no better options and it looks rather minor. Would appreciate any suggestions, though.
Maybe `hasTFE` or `enableTFE` (with default=1) would be more readable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137783/new/

https://reviews.llvm.org/D137783