[PATCH] D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added a comment.

> If `AsmMatcher` cannot report error position, why do not move the check to `AMDGPUAsmParser::validateInstruction` then?

Yes, I think the patch actually misuses `checkEarlyTargetMatchPredicate()`, which looks more like a mean to exclude unrelated instructions from viable candidates (and that's why there supposed to be no diagnostic output). Here, in contrast, we already know it that the chosen instruction is the right one, but don't want it be used, so validation should be the right point for the check, though that will require introducing another relation table, it seems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137832/new/

https://reviews.llvm.org/D137832