[PATCH] D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:3282
+    for (const auto &Op : Operands) {
+      if (static_cast<const AMDGPUOperand &>(*Op).isTFE())
+        return Match_InvalidOperand;
----------------
Joe_Nash wrote:
> foad wrote:
> > Joe_Nash wrote:
> > > I would prefer dynamic_cast, for safe downcasting.
> > LLVM is generally built with -fno-rtti so I don't think you can use dynamic_cast (can you?).
> Good point, I don't know if it's available. LLVM dyn_cast may also be an option.
the llvm pseudo-RTTI doesn't just happen and isn't implemented for AMDGPUOperand 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137832/new/

https://reviews.llvm.org/D137832