[PATCH] D137725: [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder
Jan Sjödin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 11 07:16:02 PST 2022
jsjodin added a comment.
In D137725#3919652 <https://reviews.llvm.org/D137725#3919652>, @jdoerfert wrote:
> Maybe we want a configuration object that is populated once by the user and passed to the OMPIRBuilder to cluster all such configurations, e.g., device, embedded, etc. We can also choose separators based on that internally.
Yes, I think that sounds good. Formalizing the attributes that affect codgen (in a configuration object) should make the code easier to understand/maintain. I can start working on a patch to add the configuration object.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137725/new/
https://reviews.llvm.org/D137725
More information about the llvm-commits
mailing list