[PATCH] D137723: [PDB] Don't include input files in the 'cmd' entry of S_ENVBLOCK

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 06:05:26 PST 2022


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Works for me, thanks!



================
Comment at: lld/COFF/DriverUtils.cpp:859
+  // the PDB if necessary. Mimic MSVC, which skips input files.
+  config->argv = {argv.data(), argv.data() + 1};
+  for (opt::Arg *arg : args) {
----------------
Instead of this line, maybe `config->argv.push_back(argv[0]);`? Maybe a bit more direct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137723/new/

https://reviews.llvm.org/D137723



More information about the llvm-commits mailing list