[PATCH] D137822: [IRCE] Bail out if Start AddRec is for another loop

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 03:21:21 PST 2022


mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LG with nits.



================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:849
+  if (IndVarBase->getLoop() != &L) {
+    FailureReason = "LHS in icmp not induction variable for this loop";
+    return None;
----------------
Looks weird w.r.t. messages right below, better "LHS in cmp is not an AddRec for this loop"


================
Comment at: llvm/test/Transforms/IRCE/iv-for-another-loop.ll:1
 ; RUN: opt -S -irce -irce-print-changed-loops=true < %s | FileCheck %s
 
----------------
Add new PM.


================
Comment at: llvm/test/Transforms/IRCE/iv-for-another-loop.ll:6
 
 ; REQUIRES: asserts
+; CHECK-NOT: irce
----------------
Remove this and auto-generate checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137822/new/

https://reviews.llvm.org/D137822



More information about the llvm-commits mailing list