[PATCH] D137629: [PowerPC] Use default attributes for intrinsics

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 03:11:23 PST 2022


nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1816
+        DefaultAttrsIntrinsic<[llvm_i64_ty], [llvm_double_ty], [IntrNoMem]>;
   def int_ppc_mtfsb0
       : ClangBuiltin<"__builtin_ppc_mtfsb0">,
----------------
amyk wrote:
> A question I had was, did we also mean to update these intrinsics here, as well? 
> Or are these excluded because these intrinsics have side effects?
Yeah, I skipped these originally due to the side effects. Looks like these are simple moves from/to fpscr, so default attribute should be fine for them as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137629/new/

https://reviews.llvm.org/D137629



More information about the llvm-commits mailing list