[PATCH] D137505: [SCEV] Cache ZExt SCEV expressions.

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Agreed with Nikita that generalizing it to something wider than `zext` could be a good idea. How hard is that?

One more always scares me. Any ideas how we can strengthen verifier to find problems with it? I am specifically interested in dangling pointers.



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:13745
+    for (auto &KV : ZExtUser->second)
+      ZExtCache.erase(KV);
 }
----------------
Why not `ZExtCacheUser.erase(S);` after this loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137505/new/

https://reviews.llvm.org/D137505