[PATCH] D124325: [AArch64][SVE] Support logical operation BIC with DestructiveBinary patterns

[Allen zhong via Phabricator via llvm-commits]

Allen marked 3 inline comments as done.
Allen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:494
+  case AArch64::DestructiveBinary:
+    DOPRegIsUnique = DstReg != MI.getOperand(SrcIdx).getReg();
   case AArch64::DestructiveBinaryComm:
----------------
rupprecht wrote:
> Allen wrote:
> > rupprecht wrote:
> > > rupprecht wrote:
> > > > Is fall through intended here? I assume you want a `break;`?
> > > > 
> > > > ```
> > > > llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:495:3: warning: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> > > >   case AArch64::DestructiveBinaryComm:
> > > > ```
> > > Added a break in 094c0eccdf959c3b9c85219e33c3fcfbab024b61 to avoid fallthrough. Please take a look if that's not what you want.
> > Yes, I'll add break, thanks
> Ah, race condition -- I applied the break at the same time you responded. Glad I assumed correctly :)
Thanks for fixing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124325/new/

https://reviews.llvm.org/D124325